----- Original Message -----
> > ----- Original Message -----
> > > Hi ï
> > >
> > > This 2 patches add the metric from system call shmctl(..,SHM_INFO,..)
> > > semctl(..,SEM_INFO,..) and msgctl(..,MSG_INFO,..). to pmdalinux.
> > > After add these metrics , I want to add pmipcs command to replace of
> > > Ipcs(-u/-l) command. If you have any suggestion, please tell me.
> > >
> >
> > Sounds good! Please have a look at scripts like src/pcp/{free,uptime} as
> > examples of how best to approach doing the new tool (should be a pcp-ipcs
> > with new man page, QA tests, and a src/pmlogconf/tools/ipcs file).
> Thanks your answer. I will do it.
> > Also, could you look into writing a test case for these new metrics too,
> > please?
> > The qa/888 example from earlier today should be close to what is needed for
> > regression testing here too. Thanks!
> I have writed the test case. Please refer to attachment. Thx.
>
Perfect, thanks Liming! I found a couple of small inconsistencies in the names
(e.g. "ttl" being for short for "total", where we use "tot" elsewhere for IPC),
so I made some small adjustments. Please review 'em for me & if anything looks
amiss, let me know? Thanks.
cheers.
--
Nathan
|