New OpenIndiana build failure

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi,

I've just starting seeing build failure this for the first time...

$ uname -a 
SunOS munch 5.11 oi_151a8 i86pc i386 i86pc Solaris

[...]
g++ -g -O2 -fPIC -fno-strict-aliasing -m64  -Wall -O2 -g -DPCP_DEBUG 
-DPCP_VERSION=\"3.9.0\" -I../../src/include -I../../src/include/pcp   -c 
pmmgr.cxx -o pmmgr.o
In file included from /usr/include/iso/stdlib_iso.h:46,
                 from /usr/include/stdlib.h:34,
                 from ../../src/include/pcp/pmapi.h:19,
                 from pmmgr.h:19,
                 from pmmgr.cxx:17:
/usr/include/sys/feature_tests.h:355:2: #error "Compiler or options invalid; 
UNIX 03 and POSIX.1-2001 applications      require the use of c99"
make: *** [pmmgr.o] Error 1


The following seems to workaround it (#undef doesn't strangely)...

diff --git a/src/pmmgr/pmmgr.cxx b/src/pmmgr/pmmgr.cxx
index f9de01b..cc6ecb0 100644
--- a/src/pmmgr/pmmgr.cxx
+++ b/src/pmmgr/pmmgr.cxx
@@ -12,7 +12,9 @@
  * for more details.
  */
 
+#ifndef _XOPEN_SOURCE
 #define _XOPEN_SOURCE 600
+#endif
 #include "pmmgr.h"
 #include "impl.h"


?  Or would a configure update & addition to the existing
BUILD_PMMGR check be better?

cheers.

--
Nathan