pcp
[Top] [All Lists]

[PATCH] build: add Requires for nginx and postgresql pmdas to Fedora spe

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: [PATCH] build: add Requires for nginx and postgresql pmdas to Fedora spec file.
From: Tadej JaneÅ <tadej.j@xxxxxx>
Date: Thu, 10 Sep 2015 14:53:01 +0200
Cc: pcp@xxxxxxxxxxx, Tadej JaneÅ <tadej.j@xxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1670028698.29584233.1441838482955.JavaMail.zimbra@xxxxxxxxxx>
Signed-off-by: Tadej JaneÅ <tadej.j@xxxxxx>
---
 build/rpm/fedora.spec | 3 +++
 1 file changed, 3 insertions(+)

I also tested this patch:
1) First I applied in on top of the latest Fedora downstream Spec file and
rebuilt the resulting SRPM on Copr:
https://copr.fedoraproject.org/coprs/tadej/pcp-test/

2) Then I installed both, pcp-pmda-nginx and pcp-pmda-postgresql, on fresh
Fedora 22 and CentOS 7 instances and made sure they pull in the new Requires.

diff --git a/build/rpm/fedora.spec b/build/rpm/fedora.spec
index a64c408..726e27d 100644
--- a/build/rpm/fedora.spec
+++ b/build/rpm/fedora.spec
@@ -853,6 +853,7 @@ Group: Applications/System
 Summary: Performance Co-Pilot (PCP) metrics for the Nginx Webserver
 URL: http://www.pcp.io
 Requires: perl-PCP-PMDA = %{version}-%{release}
+Requires: perl(LWP::UserAgent)
 
 %description pmda-nginx
 This package contains the PCP Performance Metrics Domain Agent (PMDA) for
@@ -922,6 +923,8 @@ Group: Applications/System
 Summary: Performance Co-Pilot (PCP) metrics for PostgreSQL
 URL: http://www.pcp.io
 Requires: perl-PCP-PMDA = %{version}-%{release}
+Requires: perl(DBI)
+Requires: perl(DBD::Pg)
 
 %description pmda-postgresql
 This package contains the PCP Performance Metrics Domain Agent (PMDA) for
-- 
1.9.3

<Prev in Thread] Current Thread [Next in Thread>