| To: | David Smith <dsmith@xxxxxxxxxx> |
|---|---|
| Subject: | Re: JSON PMDA with indom cache changes |
| From: | Nathan Scott <nathans@xxxxxxxxxx> |
| Date: | Mon, 1 Jun 2015 04:21:55 -0400 (EDT) |
| Cc: | pcp <pcp@xxxxxxxxxxx> |
| Delivered-to: | pcp@xxxxxxxxxxx |
| In-reply-to: | <55677BB7.3060805@xxxxxxxxxx> |
| References: | <555DEF05.7030108@xxxxxxxxxx> <461406362.3814890.1432280874168.JavaMail.zimbra@xxxxxxxxxx> <55677BB7.3060805@xxxxxxxxxx> |
| Reply-to: | Nathan Scott <nathans@xxxxxxxxxx> |
| Thread-index: | gB4gStbDHpiU/J4yhdmSQ6OTOAEsVA== |
| Thread-topic: | JSON PMDA with indom cache changes |
Hi David, Looking good - I've pushed this into my repo to start QA'ing it locally. Found a handful of things on final review... - missing a pmdaceph.1 man page (see src/pmdas/gluster/pmdagluster.1 for an example from another python PMDA); - missing an update to pmdacache.3 man page for the new interface - Lukas has converted fedora.spec now, so pcp-pmda-ceph is missing there, and the global python[3]-jsonpointer should be moved there; - qa/1052 could use $python for (at least) the ceph testing components to ensure good coverage for both python3 and python2 test machines (doing this uses PCP_PYTHON_PROG which aggressively tests with python3 anywhere it possibly can). Otherwise, looks good to me - just running a full QA run - will let you know if anything unexpected happens in the new tests. cheers. -- Nathan |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [pcp] pmtime needs to have AppNap disabled on OSX (#20), Nathan Scott |
|---|---|
| Next by Date: | pcp updates: dsmith+brolley merges, more pcp-atop & qa work, Nathan Scott |
| Previous by Thread: | Re: [pcp] pmtime needs to have AppNap disabled on OSX (#20), Nathan Scott |
| Next by Thread: | Re: JSON PMDA with indom cache changes, Nathan Scott |
| Indexes: | [Date] [Thread] [Top] [All Lists] |