pcp
[Top] [All Lists]

pcp updates: kenj merge, numastat, memleak fixes, qa, qa, qa

To: PCP Mailing List <pcp@xxxxxxxxxxx>
Subject: pcp updates: kenj merge, numastat, memleak fixes, qa, qa, qa
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri, 11 Apr 2014 03:12:45 -0400 (EDT)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1821183812.3777009.1397200271225.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: 6WwY9HytCe+7XPTGoOtG3MpW2ONKLg==
Thread-topic: pcp updates: kenj merge, numastat, memleak fixes, qa, qa, qa
Changes committed to git://oss.sgi.com/pcp/pcp.git dev

 man/man1/pcp.1                   |  105 ++++++++++++++++++---
 qa/366.out                       |    6 +
 qa/518                           |    4 
 qa/742                           |    6 -
 qa/743                           |   35 +++++++
 qa/743.out                       |   54 ++++++++++
 qa/900                           |  102 ++++++++++++++++++++
 qa/900.out                       |   63 ++++++++++++
 qa/929                           |   11 ++
 qa/991                           |   22 ++--
 qa/991.out                       |   18 +--
 qa/common.check                  |    2 
 qa/group                         |    2 
 qa/src/GNUlocaldefs              |    4 
 qa/src/mknuma                    |   39 +++++++
 qa/src/numa.0                    |binary
 qa/src/numa.index                |binary
 qa/src/numa.meta                 |binary
 qa/src/pcp-numastat-1-node.0     |binary
 qa/src/pcp-numastat-1-node.index |binary
 qa/src/pcp-numastat-1-node.meta  |binary
 src/libpcp/src/getopt.c          |    5 -
 src/libpcp/src/pmns.c            |   26 ++++-
 src/libpcp_pmda/src/open.c       |   34 +++++-
 src/libpcp_pmda/src/tree.c       |   16 ++-
 src/pcp/GNUmakefile              |    2 
 src/pcp/free/pcp-free.1          |  116 ++++++-----------------
 src/pcp/free/pcp-free.py         |   18 ---
 src/pcp/numastat/.gitignore      |    1 
 src/pcp/numastat/GNUmakefile     |   34 ++++++
 src/pcp/numastat/pcp-numastat.1  |   57 +++++++++++
 src/pcp/numastat/pcp-numastat.py |  157 +++++++++++++++++++++++++++++++
 src/pcp/pcp.sh                   |  194 +++++++++++++++++++++++++++++----------
 src/pcp/uptime/pcp-uptime.1      |   95 +++----------------
 src/pcp/uptime/pcp-uptime.py     |   12 --
 src/pmconfig/pmconfig.c          |   24 ++++
 src/pmdas/linux/proc_net_dev.c   |   12 ++
 src/pmlogconf/tools/localdefs    |   23 ++++
 src/pmlogconf/tools/numastat     |    4 
 src/python/pcp/pmapi.py          |   12 +-
 40 files changed, 1013 insertions(+), 302 deletions(-)

commit a797ed2ac8c1cd63150baec13a5be3c0beee931a
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri Apr 11 16:27:20 2014 +1000

    Fix memory leak reiniting PMDA hash table for dynamic metrics
    
    Test qa/957 picked up on a memory leak in the handling of the
    metric table hash lookup optimization, where second/subsequent
    calls to pmdaRehash would rewrite the hash table, accidentally
    leaking any entries written to it earlier.

commit 2ad345724188fe3ed925e66b5866ac27cf4d64af
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri Apr 11 15:52:00 2014 +1000

    Quote characters special to the shell in pmconfig(1) output

commit 7b594dda682fb83fa211220332035b6fc3e77454
Merge: 42145e6 c2377a0
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri Apr 11 15:48:49 2014 +1000

    Merge branch 'dev' of git://oss.sgi.com/kenj/pcp into dev

commit 42145e672b91bfb8a4cef29259640d9aa7493b4a
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri Apr 11 15:48:38 2014 +1000

    Support for pcp(1) running system performance scripts
    
    Add in support for pcp(1) to be used to invoke system tools
    as scripts (like the existing pcp-free, pcp-uptime scripts)
    with automatic argument passing/parsing.  So, no support is
    needed in the scripts, further simplifying them.  Man page
    updates and qa/900 is added to exercise this.
    
    The -p/-P option switch in pcp(1) is to facilitate standard
    option usage across all tools (the pmie stats are so rarely
    used this is not expected to be problem in practice).
    
    In addition, a pcp-numastat(1) script is added, along with
    pmlogconf spec, man page, qa/743 and initial archives that
    exercise it (thanks Ken).
    
    With this third script addition, the python options support
    is looking fairly solid.  The last little tweak made here is
    to automatically enable the archive boundary options, in the
    library, as it appears all scripts will want to use this by
    default.

commit c2377a0167d0f11283a2bc297dde2878c84163e0
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Apr 11 14:39:34 2014 +1000

    qa/929 - stronger filter
    
    Juggling with the NOTICES file outside the scope of the test
    and outside our control (at least easily), so filter out these
    optional lines.

commit c19913150ab58848b2c9e20491daf632f122716d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Apr 11 12:14:41 2014 +1000

    qa - numa archive

commit e6dce1ef8d358d5f6fa2b697d9b2b64bcbe65a61
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Apr 11 09:03:56 2014 +1000

    libpcp pmns - fix obscure memory leak
    
    To see this you'd need to be using PM_CONTEXT_LOCAL for a DSO
    PMDA with dynamic metrics and then call pmGetChildren() or
    pmGetChildrenStatus() and the metric at the root of the search
    needs to be a non-leaf with more than zero children.
    
    This corner case is exposed by qa/957.

commit 485860a0fb6f693bbc3f49fb5fdad251bc1907aa
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Apr 11 08:30:55 2014 +1000

    libpcp_pmda - pmdaTreeChildren tweak for dynamic metrics
    
    Tighten the guard to prevent a couple of malloc(0) cases that
    were causing qa/957 fallout.

commit 9b752b675678412cd1c77ba3738ef4df35c67b1c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Apr 11 08:27:27 2014 +1000

    libpcp - pmns traversal fixups
    
    Fixed a couple of zero-sized malloc() instances in the PM_CONTEXT_LOCAL
    case expanding the PMNS below a dynamic metric.  Tightening the guards
    prevents the pointless malloc()s.
    
    This was causing some qa/957 fallout.

commit 0ef492a9287f046542e9f61345af32313bf10f98
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Fri Apr 11 06:17:58 2014 +1000

    linux PMDA proc_net_dev.c - small initialization change for valgrind WAR
    
    Comment from the code ...
         * Note:
         * Initialization of ecmd is not really needed.  If the ioctl()s
         * work, ecmd is filled in ... but valgrind (at least up to
         * version 3.9.0) does not know about the SIOCETHTOOL ioctl()
         * and thinks the use of ecmd after this call propagates
         * uninitialized data in to ioc.speed and ioc.duplex, causing
         * failures for qa/957

commit ecfa750e321149dac484cea68fb9a34029737f5a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Thu Apr 10 11:47:40 2014 +1000

    qa/common.check - "source" is not a sh keyword
    
    I know you really meant "." not "source".

<Prev in Thread] Current Thread [Next in Thread>