pcp
[Top] [All Lists]

Re: [pcp] fche/for-merge updates (was Re: graphite interfacing prototype

To: "Frank Ch. Eigler" <fche@xxxxxxxxxx>
Subject: Re: [pcp] fche/for-merge updates (was Re: graphite interfacing prototype)
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 14 Apr 2014 06:14:00 -0400 (EDT)
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <466664093.5020375.1397463467942.JavaMail.zimbra@xxxxxxxxxx>
References: <20140414021313.GH14108@xxxxxxxxxx> <466664093.5020375.1397463467942.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: jBeK0Ew1KmDcoyOtnTrqoVkZkNU/SD4FtrxP
Thread-topic: fche/for-merge updates (was Re: [pcp] graphite interfacing prototype)

----- Original Message -----
> > [...]
> > Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
> > Date:   Sat Apr 12 23:57:34 2014 -0400
> > 
> >     pcp pmapi: fix pmConvScale parametrization
> >     
> >     The python binding to pmConvScale should be given a general pmUnits
> >     struct as a target scale, as at the C PMAPI level, not a parameter
> >     that limits us to "1 $space"-units.
> 
> Good find, however this is an API breaking change.  A fully backward
> compatible solution would be to use type(units) and switch behaviour
> based on the type of the final parameter passed in.

I've fixed this up, updated the QA code, tested & merged it now BTW,
please double check it though - thanks.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>