pcp
[Top] [All Lists]

[PATCH] Fix the description of few network metrics and expand some other

To: pcp@xxxxxxxxxxx
Subject: [PATCH] Fix the description of few network metrics and expand some others
From: Michele Baldessari <michele@xxxxxxxxxx>
Date: Wed, 3 Dec 2014 22:51:04 +0100
Cc: Michele Baldessari <michele@xxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/simple; d=acksyn.org; h= x-mailer:message-id:date:date:subject:subject:from:from:received :received; s=2010; t=1417643477; bh=CY2tuWxRtqVkUVftwpB/oXx4ERwd dfDLYrLteD/Owm0=; b=I2tKjkS3bhcA4zomBcxM5QtRBuoiZYqK2rBPSrX0BD14 pgDsiuTuVs17lxG6I7yV7PhOdjvwtSgLt/XijZVUTkby0mho79ARz+aWBViI2C3Y UeZRe56Zwe7CJAys5yMu88L991MIVr3gimNQG56WZYmHN0MkqagBB5rD4xM0/is=
The following three metrics have a wrong description:
network.interface.in.frame network recv read frames ...
network.interface.in.fifo network recv read fifos ...
network.interface.out.fifo network send fifos ...

All three are actually error counters (see net/core/net-procfs.c:
dev_seq_printf_stats()).

Improve the description of all metrics taken from /proc/net/dev
and refer to the actual structure in the kernel for easier
referencing.
---
 src/pmdas/linux/help | 34 ++++++++++++++++++++++++++++++----
 1 file changed, 30 insertions(+), 4 deletions(-)

diff --git a/src/pmdas/linux/help b/src/pmdas/linux/help
index 464f54fc39b4..4f956432d90f 100644
--- a/src/pmdas/linux/help
+++ b/src/pmdas/linux/help
@@ -709,26 +709,52 @@ Total CPU time spent running virtual guest operating 
systems.
 
 @ hinv.ninterface number of active (up) network interfaces
 @ network.interface.in.bytes network recv read bytes from /proc/net/dev per 
network interface
+bytes column on the "Receive" side of /proc/net/dev (stats->rx_bytes counter 
in rtnl_link_stats64)
 @ network.interface.in.packets network recv read packets from /proc/net/dev 
per network interface
+packets column on the "Receive" side of /proc/net/dev (stats->rx_packets 
counter in rtnl_link_stats64)
 @ network.interface.in.errors network recv read errors from /proc/net/dev per 
network interface
+errors column on the "Receive" side of /proc/net/dev (stats->rx_errors counter 
in rtnl_link_stats64)
 @ network.interface.in.drops network recv read drops from /proc/net/dev per 
network interface
-@ network.interface.in.mcasts network recv compressed from /proc/net/dev per 
network interface
-@ network.interface.in.fifo network recv read fifos from /proc/net/dev per 
network interface
-@ network.interface.in.frame network recv read frames from /proc/net/dev per 
network interface
+drop column on the "Receive" side of /proc/net/dev (stats->{rx_dropped + 
rx_missed_errors}
+counters in rtnl_link_stats64. rx_dropped are the dropped packets due to no 
space in linux buffers
+and rx_missed are due to the receiver NIC missing a packet. Not all NICS use 
the rx_missed_errors
+counter)
+@ network.interface.in.mcasts network recv multicast packets from 
/proc/net/dev per network interface
+multicast column on the "Receive" side of /proc/net/dev (stats->multicast 
counter in rtnl_link_stats64)
+@ network.interface.in.fifo network recv fifo overrun errors from 
/proc/net/dev per network interface
+fifo column on the "Receive" side of /proc/net/dev (stats->rx_fifo_errors 
counter in rtnl_link_stats64)
+@ network.interface.in.frame network recv frames errors from /proc/net/dev per 
network interface
+frame column on the "Receive" side of /proc/net/dev (stats->{rx_length_errors 
+ rx_over_errors +
+rx_crc_errors + rx_frame_errors} counters in rtnl_link_stats64
 @ network.interface.in.compressed network recv compressed from /proc/net/dev 
per network interface
+compressed column on the "Receive" side of /proc/net/dev (stats->rx_compressed 
counter in
+rtnl_link_stats64). Almost exclusively used for CSLIP or HDLC devices
 @ network.interface.out.bytes network send bytes from /proc/net/dev per 
network interface
+bytes column on the "Transmit" side of /proc/net/dev (stats->tx_bytes counter 
in rtnl_link_stats64)
 @ network.interface.out.packets network send packets from /proc/net/dev per 
network interface
+packets column on the "Transmit" side of /proc/net/dev (stats->tx_packets 
counter in rtnl_link_stats64)
 @ network.interface.out.errors network send errors from /proc/net/dev per 
network interface
+errors column on the "Transmit" side of /proc/net/dev (stats->tx_errors 
counter in rtnl_link_stats64)
 @ network.interface.out.drops network send drops from /proc/net/dev per 
network interface
+drop column on the "Transmit" side of /proc/net/dev (stats->tx_dropped counter 
in rtnl_link_stats64)
 @ network.interface.out.fifo network send fifos from /proc/net/dev per network 
interface
+fifo column on the "Transmit" side of /proc/net/dev (stats->tx_fifo_errors 
counter in rtnl_link_stats64)
 @ network.interface.collisions network send collisions from /proc/net/dev per 
network interface
+colls column on the "Transmit" side of /proc/net/dev (stats->collisions 
counter in rtnl_link_stats64)
+Counter only valid for outgoing packets
 @ network.interface.out.carrier network send carrier from /proc/net/dev per 
network interface
+carrier column on the "Transmit" side of /proc/net/dev 
(stats->{tx_carrier_errors + tx_aborted_errors +
+tx_window_errors + tx_heartbeat_errors} counters in rtnl_link_stats64).
 @ network.interface.out.compressed network send compressed from /proc/net/dev 
per network interface
+compressed column on the "Transmit" side of /proc/net/dev 
(stats->tx_compressed counter in
+rtnl_link_stats64). Almost exclusively used for CSLIP or HDLC devices
 @ network.interface.total.bytes network total (in+out) bytes from 
/proc/net/dev per network interface
 @ network.interface.total.packets network total (in+out) packets from 
/proc/net/dev per network interface
 @ network.interface.total.errors network total (in+out) errors from 
/proc/net/dev per network interface
 @ network.interface.total.drops network total (in+out) drops from 
/proc/net/dev per network interface
-@ network.interface.total.mcasts network total (in+out) mcasts from 
/proc/net/dev per network interface
+@ network.interface.total.mcasts network total (in) mcasts from /proc/net/dev 
per network interface
+Linux does not account for outgoing mcast packets per device, so this counter 
is identical to
+the incoming mcast metric
 @ network.interface.mtu maximum transmission unit on network interface
 @ network.interface.speed interface speed in megabytes per second
 The linespeed on the network interface, as reported by the kernel,
-- 
2.1.0

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] Fix the description of few network metrics and expand some others, Michele Baldessari <=