Thanks for the feedbakc Nathan.
On Thu, 2013-02-21 at 18:57 -0500, Nathan Scott wrote:
> > pmie/pragmatics.c - pow() (non-)issue
> >
> > Include open source version of pow() for platforms where this is
> > not
> > in the maths library ... only needed in this one place if
> > configure
> > determines we do not HAVE_POW.
>
> The (new) comment in the code says
> "We have not found a platform yet that needs this"
> which seems contrary to the above (if we don't need it, why...?)
In NetBSD, pow() is not in libc, so I had to add configure glue to find
if pow() is supported, and if so, in what library. This leads to the
possibility of HAVE_POW being undefined (although I don't think we have
a platform where this is true, ... yet). For completeness I added the
open source version of pow() that Sun donated to humankind a long time
ago.
> Assuming we really do need it just for this platform, I guess I'd
> anticipate it live with the other helper routines that are added
> in specifically for a platform, in src/libpcp/src/util.c (dirname,
> basename, scandir, and friends) so that when the next pow() call
> is added somewhere else in PCP, the build doesn't fail.
Good point ... I'll move it in my next commit.
> Could sanitise that code a little too - the endianness sniffing in
> there looks odd & the commented out header seems unneeded too.
Endianness _is_ odd ... I've left it alone for the moment, as I don't
think we currently have a cpp-time endianness check in the configure
glue.
The endian mess came from this header! ... comment is gone.
> > Real versions of sed (from the olden days) do not have a -i
> > command line option.
>
> Heh. Looks like "real" kernels prefer /dev/kmem readers too. :)
Hmm ... now I am pretty sure I wrote my first /dev/kmem reader code for
Sixth Edition Unix in 1976 ... no reason to believe something that
worked 37 years ago would not still work ... 8^)> (let's see how Java
and Python are making out in 30+ years ... I'll need you to check on
that, 'cause I won't be here).
Thanks again for reviewing my changes.
|