pcp
[Top] [All Lists]

pcp updates: getopts (wip)

To: PCP Mailing List <pcp@xxxxxxxxxxx>
Subject: pcp updates: getopts (wip)
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 10 Mar 2014 20:22:39 -0400 (EDT)
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1910237841.24495132.1394495119386.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: +FMQs/+9NCFK6JhnBMwDKMHuG0LHcQ==
Thread-topic: pcp updates: getopts (wip)
Changes committed to git://oss.sgi.com/nathans/pcp.git dev

 qa/728                   |    4 
 qa/src/getoptions.c      |   58 +-
 src/include/pcp/pmapi.h  |  119 ++++--
 src/libpcp/src/context.c |    4 
 src/libpcp/src/getopt.c  |  182 +++++++--
 src/pmclient/pmclient.c  |  250 +++---------
 src/pminfo/pminfo.c      |  362 ++++++------------
 src/pmprobe/pmprobe.c    |  266 +++----------
 src/pmstat/pmstat.c      |  909 +++++++++++++++--------------------------------
 src/pmstore/pmstore.c    |  131 ++----
 src/pmval/pmval.c        |  725 +++++++++++++------------------------
 11 files changed, 1109 insertions(+), 1901 deletions(-)

commit a43c17855a06f5126c476e199a36feb4542c7fc8
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Mar 10 18:14:54 2014 +1100

    Further common getopts work, converting several core client tools
    
    Added a flag into the pmOptions structure to indicate whether any
    custom namespace has been loaded (needed by pminfo).    Duplicate
    namespace names option added also.  Push the pminfo handling of a
    corrupt end-of-log into the common code, as all tools may as well
    make the most of a corrupt-looking log like it does.
    
    Conversion of several tools over to the pmGetOptions API: pminfo,
    pmprobe, pmstore, and pmval.

commit ab862aba95b9b52f6e0e8846f5796384fc36384e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Sat Mar 8 20:31:24 2014 +1100

    Further common getopts work, particularly allowing option overrides
    
    Several additions here:
    - Add -H as a standard option, and move the hostsfiles parsing and
      host list setup logic into libpcp
    - allow for client tools to override general options, via callback
    - make -H/-K/-L options available but not in the default option set
    - perform post-processing for env-only setups also (time windows)
    - add an override() function to pmOptions structure, which allows a
      client tool to intercept use of a general option if needed
    
    pmclient and pmstat are now converted over to the new world order.
    As a bonus, open-coded tv_sub in pmclient is replaced, and a bug in
    pmstat guimode handling is resolved (local: use was not setting up
    the timezone correctly, and sigsegv could result).  Several coding
    style inconsistencies in pmstat also cleaned up.

commit 9a1ebab3feeeab38adc66e5628c454bdb9cb3bb7
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Fri Mar 7 14:27:24 2014 +1100

    Small naming improvements for pmGetOptions macros
    
    Split apart the all-encompassing macro into sub-option macros,
    since most tools will need to define a subset for use, not all.
    Flags now use PM_OPTFLAG-prefix convention for clarity.

<Prev in Thread] Current Thread [Next in Thread>