Hi Paul,
----- Original Message -----
> Thanks Nathan, you're hacking away with the best of them! I've created a
> fork of Parfait on my personal account with the few commits I had while you
> were having a beer with Ryan (I mean productively discussing PCP).
>
> git@xxxxxxxxxx:tallpsmith/parfait.git
>
> I forgot to fork your one and then do a pull request, but I'm sure you can
> pull the changes you need, or even just peak at the diffs and copy it over,
> very small stuff.
Taa, I'll extract the remaining changes today - I remembered some, but not all
of the changes we (well, heh, mainly you) made, so its a bit overlapped atm.
> Also the parfait-users@xxxxxxxxxxxxxxxx is dead, google code is dead...
> Github is the primary case here (no mailing list for them though).
Ah, OK. Let's keep on using github and pcp@xxxxxxxxxxx for anyone wanting
to hack on this code for now then.
> It would be great to upgrade the Spring version that's being used eventually
> when you've got things working (may be required for things like the
> OptionalSpringFactoryBean anyway), and I wonder if Spring Boot might be a
> better simpler method eventually, but for now I would recommend you keep
> going with what you have to work towards a 0.1 releasable candidates. As
> outlined in that private email I sent you the other day, you'll have enough
> fun with the dynamic ClassLoader you'll need to wire up to bootstrap the
> agent. I'm hoping that negates the need for any shading.
+1 ... on the to-do list, and I'll take a peek at Spring Boot too, thanks.
> The AOP references you have removed are there only to automatically scan and
> instrument things that are marked with the annotations from the
> parfait-spring stuff. Something to file away in a feature tracker for
> later, not needed right now for sure.
Yep, OK - thanks.
cheers.
--
Nathan
|