Changes committed to git://oss.sgi.com/nathans/pcp.git
src/cpan/PMDA/Changes | 4
src/cpan/PMDA/PMDA.pm | 4
src/cpan/PMDA/PMDA.xs | 171 ++++++++++++++++++++++++++---------------
src/pmdas/zimbra/pmdazimbra.pl | 36 +++++++-
4 files changed, 149 insertions(+), 66 deletions(-)
commit b7087f4b8209e14c31cd19753cba7256eff65234
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Jul 7 18:31:36 2009 +1000
Not all Zimbra installations have same proc file format.
In particular, our secondary server is missing the last four
entries that are there on the primary production server, for
the proc.csv file. Make the code parsing this a little more
robust, and able to deal with arbitrary missing entries.
commit 8371ef09d24478b4e769243ecf5ef4b423cc1462
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue Jul 7 12:07:05 2009 +1000
Fix a subtle memory leak in the Perl PMDA interface.
It turns out that, for PCP::PMDA, we cannot call Perl code
from C code and expect that the G_DISCARD flag will do our
temporary variable memory cleanup for us. The reason for
this is that, in PCP::PMDA, the main flow of control is not
ever returned to Perl, where such cleanup would be done, as
we sit forever in the PMCD message loop. This is resolved
by explicitly deallocating local temporaries in all places,
not just some, and generally being more clear about where
memory is allocated and deallocated, especially in call sites
where multiple Perl functions may be called from C (fetch).
|