Bit of a mixture here ... more event records refinement, anonymous
metrics plus some real bug fixes. Most contentious changes are probably
in pmns.c and pmdaproc.sh
Changes committed to git://oss.sgi.com/kenj/pcp.git dev
src/include/impl.h | 3
src/include/pmapi.h | 8 -
src/libpcp/src/context.c | 3
src/libpcp/src/derive.c | 128 ++++++++++++++++----
src/libpcp/src/derive.h | 1
src/libpcp/src/derive_fetch.c | 4
src/libpcp/src/endian.c | 30 +++-
src/libpcp/src/events.c | 197 +++++++++++++++++++++----------
src/libpcp/src/logconnect.c | 11 +
src/libpcp/src/pmns.c | 150 ++++++++++++++----------
src/libpcp/src/util.c | 66 +++++-----
src/libpcp_import/src/archive.c | 1
src/pmcd/pmdaproc.sh | 247 +++++++++++++++++++++++-----------------
src/pmdas/sample/src/events.c | 68 +++++------
src/pmdumplog/pmdumplog.c | 88 +++++++++++---
src/pminfo/pminfo.c | 83 +++++++++++--
src/pmlogger/events.c | 9 +
src/pmstat/pmstat.c | 11 +
18 files changed, 747 insertions(+), 361 deletions(-)
commit 87a92bc4e58ea593075f1f750c3fd0032ade7949
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat Dec 4 17:27:43 2010 +1100
__pmRegisterAnon() - event record rework
Redo the anonymous metrics implementation to allow different names
to be registered.
Change the format for packed event records so that "missed" records
are encoded as an event record with er_flags set to PM_ER_FLAG_MISSED
and er_nparams set to the number missed records.
Also changed the format for the unpacked pmResult delivered via
pmUnpackEventRecords() so that er_flags is presented as an additional
event parameter for the anonymous metric event.flags and when missed
records are encountered, the number of missed records is exported as
an additional event parameter for the anonymous metric event.missed.
commit e837bcc43258466ffc62110c406f30ce8cee2cc4
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Dec 3 18:29:16 2010 +1100
pmstat - be more careful about pmLookupName() status
As part of the first round of anonymous metic changes, the logic of
pmLookupName() has been reworked to better match the original design
intent and the description in the man page. In general, some problem
is indicated by the return value != numpmid, not a value less than
zero.
commit 68492c0b96bfc41dc996c44583c7b50468a59299
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Dec 3 18:26:23 2010 +1100
pmdaproc.sh - perl Install fixups
The installation logic for a Perl PMDA was clobbering the pmns and
domain.h files ... this is sort of OK if the PMDA is _only_ ever
installed as a Perl PMDA, but for schizo cases like the simple PMDA
this cripples any attempt to install the PMDA as a non-Perl agent.
Just be more careful with the files being created, and also need to
reorder some large blocks of functionality in the install case for
all PMDAs.
commit 1a360bf588aeb7ed75a5318bf934cc8d63f994be
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Dec 3 18:08:46 2010 +1100
Anonymous metrics - first attempt
Initial cut at anonymous metrics, adding pmRegisterAnon(void) to add
anonymous metrics (PMNS and metadata) built on top of derived metrics.
Changed the event records format so that event flags are supported for
each event record, and a meta-event record with special flags is used to
mark "missing" records in situ (rather than in the header of an array
of event records). Both changes need anonymous metrics.
commit 6ead7011c7fbd91a4c9a235f59019f893cf2b45a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Dec 3 18:04:11 2010 +1100
__pmLogConnect - reinstate functionality
The last round of PDU changes removed some code that is needed to allow
pmlc to identify the pmlogger pid when a "connect port N" command is
used to connect to the pmlogger.
Put back the missing code.
commit e60cca18e5ef4afcff55762fb1cad9f6c73c5e46
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Dec 3 17:53:53 2010 +1100
pmDupContext - memory corruption with derived metrics
Found during QA for anonymous metrics ... this is a nasty error
which was probably undetected because of the infrequent use of
_both_ derived metrics and pmDupContext.
commit ec55810fb1613d1d0479989a9262f1307dcf2cfc
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Nov 29 19:54:39 2010 +1100
Event record flags
Add er_flags to the event record header and when using
pmUnpackEventRecords, if er_flags is non-zero, it is returned as
an extra initial parameter using the anon.32 anonymous metric as
the container for the value.
commit 5df955f36f3253d84cc81a182fff77edb16c9810
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Nov 29 06:17:56 2010 +1100
libpcp - add anonymous metrics
The following metrics appear in the PMNS, have a descriptor but no
values: anon.32, anon.64 and anon.double. Intended to be used for
applications and routines that rewrite pmResult structures, e.g.
pmUnpackEventRecords.
|