Hi Lukas,
----- Original Message -----
> ----- Original Message -----
> > [...]
> > Ah, thanks for catching that. As you pointed to on irc, adding an
> > autoconf check which triggers a macro definition should fix a sitation
> > like this. I've added that in commit 3ba8c73256cfb7b3 on lberk/dev.
>
> Taa.
>
> > I've tested the build on a local RHEL6 vm and everything builds
> > smoothly. Would you like another pcp updates email?
>
> (not necessary)
>
> > or is noting the commit here enough to merge?
>
> I think letting folks know like this is fine, thanks!
>
Its all merged, then I realised there may be a little issue. The man
page reference uses "papi.system.perf.BRANCH-MISSES" as an example -
is that a name that would actually come out of PAPI? (I assume so)
The problem is, the hyphen there is not valid as part of a metric name.
In some tools, like pmie, that symbol is a keyword in the language and
is used to separate tokens (so the above would be parsed as "MISSES" &
"papi.system.perf.BRANCH", with the subtraction token in-between).
The legal characters in metric names are described in pmns(5), in the
"SYNTAX" section. I guess we'll need a mapping function to translate
between the two forms (for events with invalid PMNS names, we'd need a
way to replace hyphens with underscores, for example - not sure what
other kinds of characters might appear in PAPI event names though).
cheers.
--
Nathan
|