On Mon, 2010-08-16 at 11:22 +1000, Nathan Scott wrote:
> ----- "Ken McDonell" <kenj@xxxxxxxxxxxxxxxx> wrote:
>
> > Changes committed to git://oss.sgi.com/kenj/pcp.git dev
> >
> > src/libpcp_import/src/stuff.c | 30 +
> > src/libpcp_pmda/src/open.c | 13
> > src/pmdas/bozo/GNUmakefile | 49
> > ++
> > src/pmdas/bozo/Install | 31 +
> > src/pmdas/bozo/Remove | 29 +
> > src/pmdas/bozo/domain.h | 1
> > src/pmdas/bozo/pmdabozo.pl | 60
> > ++
>
> Hmm ... does this belong here or in pcpqa/src-oss? We have a plethora
> of example PMDAs (including simple.c and pmdasimple.pl, txmon, trivial,
> sample, etc) already, maybe too many. :)
Agreed ... I've removed it from my tree.
> > src/pmimport/examples/20624-copyright_permission_letter.pdf |binary
> > src/pmimport/examples/GNUmakefile | 37 +
> > src/pmimport/examples/README | 13
> > src/pmimport/examples/mk.mover.log | 35 +
> > src/pmimport/examples/mover.log | 161
> > ++++++
> > src/pmimport/examples/mover2pcp | 277
> > ++++++++++++
> > src/pmimport/examples/moverv1 | 26 +
> > src/pmimport/examples/moverv2 | 29 +
> > src/pmimport/examples/moverv3 | 40 +
> > src/pmimport/examples/moverv4 | 54
> > ++
> > src/pmimport/examples/weather.dat | 156
> > ++++++
>
> Wondering if this should this live in the tutorial? Not sure. Might be
> more likely to be found there? Or, might not. :) It would seem like it
> should be part of pcp-doc package, anyway... rather than core pcp, and
> it should probably use PCP_DEMOS_DIR for installation (the diskmodel tute
> is an example of how I was tackling this sort of thing, wrt source tree
> structure, packaging, etc).
I'm not so sure on this one. I include the mover2pcp in the annotated
documentation of howto.importdata.html in pcp-doc. There is an uneasy
cross-tree and cross-package relationship here between the libraries,
the Perl wrapper, the shipped tools (sheet2pcp, sar2pcp, etc) and the
documentation example.
I initially chose to leave the real example living in the PCP source
tree, following the precedent of src/pmie/examples. Which is why the
installation directory was $(PCP_SHARE_DIR)/examples. On reflection,
this could have been included in a mover2pcp subdirectory alongside
diskmodel, so I'll move it there (which avoids the ugly hack to reach
across to the pcp tree to find mover2pcp).
The PDF file and weather.dat are the remnants of an earlier idea I had
to use meteorlogical data for howto.importdata.html ... I'll just remove
them from the source tree.
Commits for both trees are on their way.
Thanks for the feedback Nathan.
|