Re: [pcp] Secure sockets - unnecessary client certificate initialization issue

[Nathan Scott <nathans@xxxxxxxxxx>]

----- Original Message -----
> The current code tries to load certificates for any client even those
> that have no interest in using secure sockets.
> 
> This causes an empty $HOME/.pki/nssdb to be created, which is at the
> root of my earlier "security" issue.
> 

This one seems fairly benign at least.

> We should not be doing anything on the client side unless
> $PCP_SECURE_SOCKETS is set to something interesting in the environment.

Or a context is explictly created with the context flag ... its not as
simple as just checking an env var, its possible to create secure and
non-secure contexts from within a single tool (pmchart).

So, we can take load_certificate_database() out of the __pmConnectPMCD
one-trip guard and add separate global state for this I guess.

cheers.

--
Nathan