This allows pmlogger to work with derived metrics in the configuration
file.
There remains an issue for pmchart and the additional tab launched after
recording is finished (pminfo inherits the setting of
$PCP_DERIVED_CONFIG and the operands for the derived metrics are not in
the archive, even if the values for the derived metric(s) are in the
archive).
Changes committed to git://oss.sgi.com/kenj/pcp.git dev
man/man3/pmfetch.3 | 2 -
src/libpcp/src/derive_fetch.c | 38 ++++++++++++++++++++-----------
src/libpcp/src/fetch.c | 12 ++++++----
src/pmlogger/fetch.c | 50 +++++++++++++++++++++++++++++++++++++++---
4 files changed, 80 insertions(+), 22 deletions(-)
commit fdeb64794b2f4a4e06e6457f9a3b9d9fa1901596
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon May 10 20:25:06 2010 +1000
derived metrics & pmlogger - fix
Fix to allow pmlogger to log derived metrics. Logic lifted from libpcp
to preprocess and postprocess pmFetch calls and grafted into pmlogger's
myFetch routine.
In the archive, the derived metric is logged just like a real metric,
so name in the pmns, pmid as allocated by pmRegisterDerived, pmDesc
from expression tree and values from the the pmResult rewriting using
the expression tree.
commit a1b19e97ebb88a43db899bb4a57e941890278e80
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon May 10 20:23:16 2010 +1000
pmFetch man page - fix typo
commit dc77952a340a24df64f609871cd9f42f8bc1ccb5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon May 10 20:15:10 2010 +1000
derived metric - fix segv
Bad expr deref when a metric operand is bad ... move guard into correct
place. Problem only would have been seen with a wonky derived metric
specification.
|