On Mon, 2009-02-02 at 20:05 +1100, Ken McDonell wrote:
> For this one, we already have configure support to set
> #define HAVE_GETOPT_NEEDS_POSIXLY_CORRECT 1
> in platform_defs.h, but then we don't seem to use it any place in the
> code (!!).
Oh, it is used in src/pmcd/src/pmcd.c after all, on a closer
look (at least, it is in my tree). Used in pmstore too.
> I suggest if this is set in the build, then pmcd should force the
> setting of POSIXLY_CORRECT in its own env before launching any pmdas.
dbpmda should do this too, woulda saved me from that red herring
- I'll make it so.
> ps. Changing the semantics of getopt() to pander to laziness is a piece
> of gnu pixie brain fart that should have killed at birth!
Tell us what you really think. :)
OK, found it - the pmie log rotation changes were the cause
(shouldn't allow that in secret-agent mode anyway) - we need
a test which just installs the summary PMDA with the default
config, that would've caught this.
cheers.
--
Nathan
|