Hi Marko,
----- Original Message -----
> Hi,
>
> I noticed that libpcp and most PCP clients report count per second as
> "count / sec" but pmrep(1) uses "count/s" (for non-raw counters).
>
Yeah, its pmUnitsStr_r(3) in libpcp producing this form IIRC.
> What do you think about the patch below, could we unify the output? I
> perhaps slightly prefer the more compact output but in the end it might
I tend to prefer the compact output too for pmrep, which has strategies
for producing short column headings that other tools don't employ - so I
think its fine as-is. But that's just me...
> be better to be consistent all across the board. Alternatively, we
> could of course make pmrep(1) to always use "/s". (If yes, this would
> require regenerating/tweaking for QA test case outputs.)
Up to you - if you do choose a new strategy please send through code and
test updates together, makes life easier at this end. Thanks!
cheers.
--
Nathan
|