Hi Dave,
----- Original Message -----
> On 07/09/2014 03:38 AM, Nathan Scott wrote:
> >
> > I've pulled all your current work, but had some problems with a
> > few tests (see attached bad files). I found reverting the commit
> > below got us back into a healthy state, so pushed this for now -
> > when you figure it out, just "git revert" on my revert should do
> > a revert revert & then just apply your followup fix on top).
>
> I just redid the change in my pcpfans brolley/dev branch. That in addition
> to the fix which was to add EINPROGRESS handling to a few callers of
> __pmConnect().
Ah, OK, sounds promising. From a full QA run though I have new failures
in tests 230, 775, 835, and 946 that all appear related to these changes.
835 is the new pmdamemcache test, but it was running reliably on Friday
- with the latest pull, not so much (it now times-out during the initial
pmcd connection). I've attached all the bad files (ip addr for the host
is 192.168.122.1 - for the 775 and 946 failures).
> I don't think I have permission to do reverts on the dev branch of the
> SGI repository, and I would be too afraid to mess it up anyway, so
Couple of clarifications - there is no "SGI repository" (our use of git
began after SGI involvement in PCP was largely winding down, and the
community needed to find a way to exchange code and manage the releases
independently).
Re the git revert - doesn't matter, but it could've been done in your own
tree & then pulled into the main dev branch (just like everything else).
But, its of no consequence 0 at the end of the day, we just want the issue
fixed, so use whatever is the most convenient way to reach that point -
your commitlog explained it just fine.
cheers.
--
Nathan
946.out.bad
Description: Binary data
835.out.bad
Description: Binary data
775.out.bad
Description: Binary data
230.out.bad
Description: Binary data
|