pcp
[Top] [All Lists]

Re: [PATCH 01/12] Fix Windows PMDA build

To: Michael Newton <kimbrr@xxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH 01/12] Fix Windows PMDA build
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Wed, 06 Dec 2006 16:35:46 +1100
Cc: Mark Goodwin <markgw@xxxxxxx>, pcp@xxxxxxxxxxx
In-reply-to: <1165381359.1281.113.camel@edge>
Organization: Aconex
References: <1163999314.4695.231.camel@edge> <1164321131.4695.368.camel@edge> <Pine.SGI.4.58.0612061551470.53803701@snort.melbourne.sgi.com> <1165381359.1281.113.camel@edge>
Reply-to: nscott@xxxxxxxxxx
Sender: pcp-bounce@xxxxxxxxxxx
Hi Michael,

On Wed, 2006-12-06 at 16:02 +1100, Nathan Scott wrote:
> On Wed, 2006-12-06 at 15:52 +1100, Michael Newton wrote:
> > On Fri, 24 Nov 2006, Nathan Scott wrote:
> > > On Mon, 2006-11-20 at 16:08 +1100, Nathan Scott wrote:
> > > > Currently the Makefile for the Windows agent is in a half-broken state,
> > > > it assumes in some places that uuencoding has been done on certain files
> > > > where it has not (uuencode/uudecode doesn't seem to be part of a default
> > > > Cygwin install either).
> > > >
> > > > This reverts the Windows PMDA Makefile to its earlier, working state.
> > >
> > > Don't worry about this patch for now, I'll send in a patch early next
> > > week to fix this up properly.
> > 
> > is this still to come or did i miss it? cheers, m.

OK, I discussed this with Ken, and we agreed that the patch I sent
over earlier is what we should go with.  The main issue here is to
do with getting new versions of src/pmdas/windows/*.save into the
distributed PCP tarballs, and we decided to put it back how it was
originally, and send those files to you separately (on the rare
occassions that they need to be re-generated).

I did notice one unrelated issue when doing a test build just now,
however - you'll need this (incremental) patch to get a source tar
ball which can build itself, otherwise theres a missing config file
and the build goes belly up in the build-src-tarball phase (only in
the case of a build from the source generated from the source, if
you see what I mean - not the normal case of building in a patched
workarea - a quirk of the Makefile's LSRCFILES macro use).

cheers.

-- 
Nathan

Attachment: fix-stomp-lsrcfiles
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>