pcp
[Top] [All Lists]

[PATCH 04/12] Fix pagefault metrics

To: Michael Newton <kimbrr@xxxxxxx>, Mark Goodwin <markgw@xxxxxxx>
Subject: [PATCH 04/12] Fix pagefault metrics
From: Nathan Scott <nscott@xxxxxxxxxx>
Date: Mon, 20 Nov 2006 16:09:34 +1100
Cc: pcp@xxxxxxxxxxx
Organization: Aconex
Reply-to: nscott@xxxxxxxxxx
Sender: pcp-bounce@xxxxxxxxxxx
The page fault metrics in the Linux PMDA are maintained as counters in
the kernel, but we're currently exporting them as discrete values.  This
means they're not handled correctly in most client tools.

-- 
Nathan

Index: devel-pcp-2.5.99/src/pmdas/linux/pmda.c
===================================================================
--- devel-pcp-2.5.99.orig/src/pmdas/linux/pmda.c 2006-11-20
11:27:21.083509000 +1100
+++ devel-pcp-2.5.99/src/pmdas/linux/pmda.c 2006-11-20
11:27:38.748613000 +1100
@@ -1142,22 +1142,22 @@ static pmdaMetric metrictab[] = {

/* proc.psinfo.minflt */
   { NULL,
-    { PMDA_PMID(CLUSTER_PID_STAT,9), PM_TYPE_U32, PROC_INDOM,
PM_SEM_DISCRETE, 
+    { PMDA_PMID(CLUSTER_PID_STAT,9), PM_TYPE_U32, PROC_INDOM,
PM_SEM_COUNTER,
     PMDA_PMUNITS(0,0,0,0,0,0) } },

/* proc.psinfo.cmin_flt */
   { NULL,
-    { PMDA_PMID(CLUSTER_PID_STAT,10), PM_TYPE_U32, PROC_INDOM,
PM_SEM_DISCRETE, 
+    { PMDA_PMID(CLUSTER_PID_STAT,10), PM_TYPE_U32, PROC_INDOM,
PM_SEM_COUNTER, 
     PMDA_PMUNITS(0,0,0,0,0,0) } },

/* proc.psinfo.maj_flt */
   { NULL,
-    { PMDA_PMID(CLUSTER_PID_STAT,11), PM_TYPE_U32, PROC_INDOM,
PM_SEM_DISCRETE, 
+    { PMDA_PMID(CLUSTER_PID_STAT,11), PM_TYPE_U32, PROC_INDOM,
PM_SEM_COUNTER, 
     PMDA_PMUNITS(0,0,0,0,0,0) } },

/* proc.psinfo.cmaj_flt */
   { NULL,
-    { PMDA_PMID(CLUSTER_PID_STAT,12), PM_TYPE_U32, PROC_INDOM,
PM_SEM_DISCRETE, 
+    { PMDA_PMID(CLUSTER_PID_STAT,12), PM_TYPE_U32, PROC_INDOM,
PM_SEM_COUNTER, 
     PMDA_PMUNITS(0,0,0,0,0,0) } },

/* proc.psinfo.utime */



<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH 04/12] Fix pagefault metrics, Nathan Scott <=