Hi Marko,
----- Original Message -----
> [...]
> Please see below for an initial draft patch which adds currently the missing
> metrics. But please note few things, perhaps you could help with these?
Sure thing ...
> pminfo can't find rpc.server.reqcounts{,3,4}, there's some code to populate
> them but I'm not sure is the corresponding code in pmda.c correct. Also,
It looks like this is the nfs{,3,4}.server.reqs metrics ... they
seem OK at first glance - were they too well hidden, or are they
not working? See approx line 4950 in pmda.c for nfs3.server.reqs
which exports proc_net_rpc.server.reqcounts3[inst], where "inst"
is the set of NFS3 operations.
> they are not listed in the root_linux pmns definition file. Since I'm not
> clear about this I didn't add the needed code for th_usage/ra_depth to
> pmda.c (of these th_usage is actually helpful, not sure how relevant
> ra_depth is for most people). It seemed also that not all server.rpc* were
> properly collected, adjusted that.
Looks good to me - if you found 'em useful, lets go ahead and add the
new metrics in. I can see the few missing code spots so I'll do that
on top of your patch.
I'm outta time for today, I'll add that code and a new test on Monday
- thanks for the sample file!
cheers.
--
Nathan
|