Hi Martins,
----- Original Message -----
> Hi,
>
> Attached is an updated infiniband pmda that includes metrics
> gathered from the switch counters. The HCA counters are only 32 bit
> while the switch metrics are 64 bit counters. We have done some initial
> validation, and the values seem to be correct for the simple tests we
> have run so far. Testing is still ongoing, but I wanted to send our
> current work out for comment.
Looks good to me. I think you're carrying the team when it comes to
testing the infiniband pmda, so thank you! I got the warnings below,
and also I think you'll need an update to the text in the "help" file
else the Install script will give warnings?
Maybe this spot might be slightly more clear if the comment was turned
into code, too:
- pst->needupdate = 3; /* 0x1 for portinfo, 0x2 for perfdata */
+ pst->needupdate = 11; /* 0x1 for portinfo, 0x2 for perfdata, 0x8 for switch
e.g. pst->needupdate = IB_PORTINFO | IB_PERFDATA | IB_SWITCH
(with appropriate #defines, better names, etc)
gcc -fPIC -fno-strict-aliasing -D_GNU_SOURCE -fstack-protector-all
-D_FORTIFY_SOURCE=2 -Wall -g -DPCP_DEBUG -DPCP_VERSION=\"3.9.7\"
-I../../../src/include -I../../../src/include/pcp -c -o ib.o ib.c
ib.c: In function âib_fetch_valâ:
ib.c:666: warning: pointer targets in passing argument 1 of âmad_decode_fieldâ
differ in signedness
/usr/include/infiniband/mad.h:1170: note: expected âuint8_t *â but argument is
of type âchar *â
ib.c:667: warning: pointer targets in passing argument 1 of âmad_decode_fieldâ
differ in signedness
/usr/include/infiniband/mad.h:1170: note: expected âuint8_t *â but argument is
of type âchar *â
ib.c:893: warning: pointer targets in passing argument 1 of âmad_decode_fieldâ
differ in signedness
/usr/include/infiniband/mad.h:1170: note: expected âuint8_t *â but argument is
of type âchar *â
ib.c:899: warning: pointer targets in passing argument 1 of âmad_decode_fieldâ
differ in signedness
/usr/include/infiniband/mad.h:1170: note: expected âuint8_t *â but argument is
of type âchar *â
ib.c:904: warning: pointer targets in passing argument 1 of âmad_decode_fieldâ
differ in signedness
/usr/include/infiniband/mad.h:1170: note: expected âuint8_t *â but argument is
of type âchar *â
ib.c:910: warning: pointer targets in passing argument 1 of âmad_decode_fieldâ
differ in signedness
/usr/include/infiniband/mad.h:1170: note: expected âuint8_t *â but argument is
of type âchar *â
ib.c:917: warning: pointer targets in passing argument 1 of âmad_decode_fieldâ
differ in signedness
/usr/include/infiniband/mad.h:1170: note: expected âuint8_t *â but argument is
of type âchar *â
ib.c:919: warning: pointer targets in passing argument 1 of âmad_decode_fieldâ
differ in signedness
/usr/include/infiniband/mad.h:1170: note: expected âuint8_t *â but argument is
of type âchar *â
ib.c:927: warning: pointer targets in passing argument 1 of âmad_decode_fieldâ
differ in signedness
/usr/include/infiniband/mad.h:1170: note: expected âuint8_t *â but argument is
of type âchar *â
ib.c:929: warning: pointer targets in passing argument 1 of âmad_decode_fieldâ
differ in signedness
/usr/include/infiniband/mad.h:1170: note: expected âuint8_t *â but argument is
of type âchar *â
cheers.
--
Nathan
|