----- Original Message -----
>
> From pcpfans commit #b171d777de6d:
>
> Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
> Date: Tue Oct 14 15:24:43 2014 -0400
>
> Makepkgs: on RH platforms, use rpm --eval ... for fuller ./configure
Looks good to me and resolves a long-standing issue I've had to workaround
- thanks!
I don't follow the --program-prefix=%{?_program_prefix} part at the start
of the rpm invocation though - how does that bit work? Does that assume a
_program_prefix can be passed into rpm, which (I think?) cannot be, in our
use here? (and, do we use _program_prefix anywhere? what's its relation
to --prefix?). Its very likely I'm missing some subtlety there, sorry.
Later on in Makepkgs, we drive the setting of "nonrpm" based on presence
of /usr/bin/rpmbuild (IOW, if that's found, and not explicitly asked to do
another type of packaging, we *will* choose rpm packaging)... it'd be good
to use the rpm-based settings always in that situation and not only if its
a Red Hat system (I think this is what you mean by the "and other?" comment
in the code?). The script would need some refactoring to deal properly with
its command line arguments - so I wouldn't worry about it for now, but maybe
we can revisit that later as a more general improvement.
cheers.
--
Nathan
|