Changes committed to git://oss.sgi.com/pcp/pcp.git dev
qa/.gitignore | 1
qa/069.out.ipv4 | 2
qa/069.out.ipv6 | 2
qa/083 | 1
qa/098 | 4
qa/098.out | 102 ++--
qa/100 | 4
qa/100.out | 102 ++--
qa/101 | 4
qa/101.out | 102 ++--
qa/103 | 4
qa/103.out | 102 ++--
qa/104 | 4
qa/104.out | 102 ++--
qa/105 | 4
qa/105.out | 102 ++--
qa/106 | 4
qa/106.out | 102 ++--
qa/172 | 2
qa/172.out.2 | 1
qa/183 | 5
qa/183.out.irix | 4
qa/183.out.linux | 4
qa/368 | 14
qa/368.darwin.3 | 218 ++++++++++
qa/368.other.3 | 215 ++++++++++
qa/381 | 1
qa/439.out | 6
qa/497 | 12
qa/497.out | 136 ------
qa/497.out.1 | 136 ++++++
qa/497.out.2 | 138 ++++++
qa/common.check | 5
src/include/pcp/impl.h | 12
src/libpcp/src/accounts.c | 54 ++
src/libpcp/src/check-statics | 6
src/libpcp/src/exports | 25 -
src/libpcp/src/internal.h | 1
src/libpcp/src/logconnect.c | 846 ++++++++++++++++++++++++-----------------
src/libpcp/src/logportmap.c | 77 ++-
src/libpcp/src/secureconnect.c | 78 +--
src/libpcp/src/util.c | 32 +
src/pmlc/actions.c | 18
src/pmlc/gram.y | 34 +
src/pmlc/lex.l | 11
src/pmlc/pmlc.c | 92 +++-
src/pmlogconf/pmlogconf.sh | 6
src/pmlogger/src/gram.y | 3
src/pmlogger/src/lex.l | 23 +
src/pmlogger/src/logger.h | 8
src/pmlogger/src/pmlogger.c | 26 -
src/pmlogger/src/ports.c | 487 +++++++++++++++++------
52 files changed, 2375 insertions(+), 1109 deletions(-)
commit 8f75d3acc9c0bdee1cc7b994c149c9663457fd88
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Mar 20 15:25:27 2014 +1100
Remaining qa test fallout from local: pmlc/pmlogger connections
commit 1b086dfe2515c502b890dd67364ed2af62c05aea
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Mar 20 14:08:20 2014 +1100
Fix test qa/083 handling of local: pmlogger/pmlc connections
commit 23dfcd45668d2076dfceeeb96d80a42b06240fe6
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Mar 20 14:05:30 2014 +1100
Fix build on RHEL5 i386 where libpcp has unexpected statics
$ ./check-statics
rtime.o: d startend_relative_terms.9369 : Error: additional symbol
commit a169ae8dffc596178b0857d5ea214750565ec3ae
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Mar 20 13:18:17 2014 +1100
Move new libpcp symbols into new exports section
commit 2713664923f396052aefe8200c587c8d6ef109f5
Merge: 0d9ae9b c615547
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Mar 20 12:38:14 2014 +1100
Merge branch 'brolley/dev' of ../pcpfans into dev
commit c6155474816c87fe4d2692eb9d78124f10be65c8
Merge: f06a7f0 d03e715
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 18 11:44:59 2014 -0400
Merge remote-tracking branch 'origin/dev' into brolley/dev
Conflicts:
src/libpcp/src/exports
commit f06a7f06b614feefea14f27b2723ed8606de9e8f
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 18 11:41:57 2014 -0400
For pmlogger control connections via AF_UNIX, check the connector's
credentials.
This initial implementation allows connections by root and
by the same user as the one running pmlogger.
commit 5fb01b56fef929df01a9c005a85f1843aff6cc2c
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Mon Mar 10 11:02:06 2014 -0400
Fix __pmConnectLogger() access control bug for the "local:[path]".
When pmlc uses local:[path] is specified, __pmConnectLogger()
should attempt connection as "unix:[path]" and, if this fails,
it should try again as "localhost".
This was working ok for the case when connection via unix:
could not be established. However when the connection was established
but terminated due to insufficient access control permissions,
__pmConnectLogger() did not go on to try connecting as "localhost".
Also, -ECONNREFUSED was being returned in this case instead of -EPERM.
commit d59bbcf3f00d84f3f5c1a002a950634c06b4cb2a
Merge: 5046073 1ec7d74
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Wed Mar 5 12:14:09 2014 -0500
Merge remote-tracking branch 'origin/dev' into brolley/dev
commit 5046073d44836ff02af15630ba39e06cd4a3d0a5
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 4 16:55:16 2014 -0500
Error messages now correctly refer to pmlogger, not pmcd.
commit 9349d8641aa681b493c616f43258860965e48e90
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 4 16:24:25 2014 -0500
Fix socket fd leak in GetPorts() (pmlogger).
commit 3b2eb2e0fb19e48b4dcca7782bf656afa12966bd
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 4 16:18:10 2014 -0500
Call __pmNoMem() in ConnectPMCD() (pmlc) when out of memory.
commit fdbc97d3903c33f96580808fcef8a77376db4dc5
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 4 16:12:43 2014 -0500
Rework the flow of logic in the NSPR implementation of __pmGetNameInfo().
commit b01572d581dea4adffd839d8e339656349e63b3d
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 4 15:51:09 2014 -0500
Fix memory lead (ctxhost) in __pmLogFindPort()
commit e5b3075f4617597e22f5ba88fb0078e51b4c8fa4
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 4 15:43:05 2014 -0500
Fix fd leak in connectLoggerLocal()
commit 707b499d8fd9867be47bfae2c0d2f2e2b226aa33
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 4 15:22:23 2014 -0500
Rename of __pmMkDir() to __pmMkPath() should have been to __pmMakePath().
The actual name suggested in the code review.
commit fb5b05c1b1dabc4185263b87fd96f766621d2a62
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 4 15:04:11 2014 -0500
Code formatting and typo fixes as recommended by code review.
Items mentioned in the code review for AF_UNIX sockets for
pmlogger/pmlc.
commit 9aabf24a17e71cff1c221a184d875b8f0ea0d76a
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Mar 4 14:32:16 2014 -0500
Change the API for __pmLogLocalSocketDefault() and __pmLogLocalSocketUser().
- Buffers are no longer static within the function.
- Buffers and size are now passed in by th caller.
- No need for PM_LOCK anymore.
- Update all callers.
- Update check-statics
commit d2e87db1c006c98067e05fac25c354dec79923c3
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Mon Mar 3 17:35:21 2014 -0500
__pmHomedirFromID() now returns NULL on error.
All Callers updated.
commit 138d204590757960879499918315e725aa4fb920
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Mon Mar 3 17:31:25 2014 -0500
Rename __pmMkdir() to __pmMkPath() and add new exports to the PCP_3.2
section.
commit f3dba49cafd9da8a68d686b433bca3197c51f29e
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Mon Mar 3 12:50:06 2014 -0500
For ordinary users, create the AF_UNIX pmlogger control socket in
~/.pcp/run/
Created as ~/.pcp/run/pmlogger.<pid>.socket
commit 22ffbdab17809cc4fd0475a27d02ffa7a580059b
Merge: 6f89daa 638aea3
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Fri Feb 28 15:21:54 2014 -0500
Merge remote-tracking branch 'origin/dev' into brolley/dev
commit 6f89daa0c76bfb53267b5367e40c0815dd0fd738
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Fri Feb 21 09:02:54 2014 -0500
Bump pcp version check for qa tests 368 and 497 to 3901.
pmlogger/pmlc AF_UNIX changes missed release 3.9.0
commit bf0ae86bf9e7f7e4e468546cb65d5c833744724f
Merge: aabeef7 1b7cda1
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Fri Feb 21 08:31:45 2014 -0500
Merge remote-tracking branch 'origin/dev' into brolley/dev
commit aabeef72f915d50fcaec4ea168d282b23b184ea7
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Fri Feb 21 08:28:30 2014 -0500
Create pmLogger AF_UNIX socket under the home directory for normal users.
When a normal user runs pmlogger, the AF_UNIX socket cannot be created
in the normal system-wide location, since that location is not world
writable. In this case, create the socket under the user's home
directory (i.e. under ~/.pcp).
commit 77d1dc5d8d2389672fd99f48b9c7f385feb951af
Merge: 3685cfa dec7155
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Tue Feb 18 10:46:53 2014 -0500
Merge remote-tracking branch 'origin/dev' into brolley/dev
commit 3685cfa7480a900e6df591762cd79a06467204ac
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Mon Feb 17 11:37:53 2014 -0500
Handle unix domain socket binding (creation) for pmlogger when run as a
normal user.
When running as a normal user, pmlogger is unable to bind to
(i.e. create) a unix domain socket in /var/run/pcp (PCP_RUN_DIR),
because that directory is not writable by normal users. This change handles
the situation in a similar way to how the port map file in
/var/lib/pcp/tmp/pmlogger (PCP_TMP_DIR)/pmlogger is handled, which is to
continue on an to issue a message only if DESPARATE is defined
at compile time.
This solution is reasonable, since pmlogger will go on to create
inet and ipv6 sockets for control connections. Only if all
sockets fail to bind is this a critical error.
This addresses the regression of qa tests 039 046 053 085 161 178
234 242 248 304 352 354 466 524 593 and 650.
commit 2b10b054d906150c3fe006f812b57c7787f71f4b
Merge: 14098f8 2e72eb8
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Fri Feb 14 11:45:47 2014 -0500
Merge remote-tracking branch 'origin/dev' into brolley/dev
commit 14098f8b0f89f6364fdadcad2523a381069db3d4
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Fri Feb 14 11:43:34 2014 -0500
Fix qa fallout from ipv6/unix socket implementation for pmlogger/pmlc.
Address output differences caused by the default host now being
local:
Addresses regressions in qa tests 098 100 101 103 104 105 106 172 183 368
497
commit 71b527021a9c9b366a802bf54777b9063fcc12a3
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Fri Feb 14 11:41:12 2014 -0500
Tighten up lexical definition of a host url.
Addresses qa fallout for test 645 from the ipv6/unix: socket
implementation for pmlogger and pmlc.
commit 83d4c2df654aab4caa2f808c143ace8268e45f45
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Fri Feb 14 11:39:00 2014 -0500
Return actual status code from connectLogger.
Was returning -1 on error.
Addresses qa fallout for qa test 439 from ipv6/unix socket
implementation for pmlogger.
commit 5246cf21147191e3b1ef6d9448f0b92f5a2e9d2a
Merge: 64ba262 8fe72ef
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Wed Feb 12 17:06:22 2014 -0500
Merge remote-tracking branch 'origin/dev' into brolley/dev
commit 64ba262d1beb232703013db4001cb512d1790ff3
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Wed Feb 12 17:02:49 2014 -0500
Support ipv6 and unix domain socket control connections in pmlogger and
pmlc.
pmlogger now listens on ipv6 and on a local unix domain socket
(on supported platforms) for control connections.
pmlc can now use ipv6 addresses as well as unix:{path] and
local:[path] urls to connect to pmlogger.
commit dcf64bb7b71d3d0aa3717ec79ff3a3c1d613031b
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Wed Feb 12 10:37:12 2014 -0500
pmlc: ConnectPMCD: Catch potential NULL return from strdup.
commit 8e8684fd55ed95627bca8b20f67c3c633e651721
Author: Dave Brolley <brolley@xxxxxxxxxx>
Date: Wed Feb 12 10:32:53 2014 -0500
Handle PR_AF_LOCAL in the NSPR implementation of __pmGetNameInfo.
Was already handled by the native implementation.
|