Re: [pcp] pmrep: fix timezone handling/reporting

[Nathan Scott <nathans@xxxxxxxxxx>]

Hi Marko,

----- Original Message -----
> [...]
> > As discussed in that other thread, we've managed to avoid some helper
> > routines in pmrep (pmGetContextOptions in particular) which might've
> > made some of this easier, not sure (if we are really out of sync, we
> > will not be helped by that I guess).
> 
> One reason why we've avoided using pmGetContextOptions in pmrep is that
> it's not available via the Python PMAPI :-)

Its there, its just not directly called - pmContext.fromOptions builder
interface makes use of it (hmm, which pmrep already uses?) via:

        # finish time windows, timezones, archive access mode
        if c_api.pmSetContextOptions(context.ctx, options.mode, options.delta):
            raise pmUsageErr

(which internally calls pmGetContextOptions)

> > So if we cannot use the helper APIs then this patch looks OK to me.
> 
> Perhaps we could start with this then to get the situation under control
> and later on consider pmGetContextOptions if it becomes available and
> makes the code easier to read?

Sure.

cheers.

--
Nathan