Re: [bonding] Add basic support for dynamic configuration of bond interfaces

[Jason Lunz <lunz@xxxxxxxxxxxx>]

jgarzik@xxxxxxxxx said:
> The key question is what is the best interface for userland to configure 
> in-kernel information -that is unrelated to a specific interface-. 
> ethtool ioctl space doesn't apply, because that's a per-interface API.

ethtool is just as bad as brctl or any of the others. From (userland)
ethtool.c:

        static int doit(void)
        {
                struct ifreq ifr;
                int fd;

                /* Setup our control structures. */
                memset(&ifr, 0, sizeof(ifr));
                strcpy(ifr.ifr_name, devname);
                /* Open control socket. */
                fd = socket(AF_INET, SOCK_DGRAM, 0);
                if (fd < 0) {
                        perror("Cannot get control socket");
                        return 70;
                }

                /* now do ioctl() on fd, having nothing to do with
                 * AF_INET nor SOCK_DGRAM */

calling a spade a spade, and all that. I don't see how that's any better
than brctl. The per-interface only comes into it when you copy a dev
name into a struct ifreq, but that doesn't associate the fd with the
interface in any way. You could go ahead and issue another ioctl on the
same fd for a different interface. 

Jason