netdev
[Top] [All Lists]

[PATCH] Memory leak in iptables

To: torvalds@xxxxxxxxxxxxx
Subject: [PATCH] Memory leak in iptables
From: Rusty Russell <rusty@xxxxxxxxxxxxxxxx>
Date: Thu, 27 Apr 2000 19:30:28 +0930
Cc: netdev@xxxxxxxxxxx, havanna_moon@xxxxxxx, netfilter@xxxxxxxxxxxxxxx
Sender: owner-netdev@xxxxxxxxxxx
Linus, please apply v2.3.99-pre6.

Kudos to Yon Uriarte for finding it.
Rusty.

diff -urN --minimal --exclude *.lds --exclude *.ps --exclude *.pdf --exclude 
*.sgml --exclude *.tex --exclude *.aux --exclude *.log --exclude classlist.h 
--exclude devlist.h --exclude autoconf.h --exclude compile.h --exclude 
version.h --exclude .* --exclude *.[oa] --exclude *.orig --exclude config 
--exclude asm --exclude modules --exclude *.[Ss] --exclude System.map --exclude 
consolemap_deftbl.c --exclude *~ --exclude TAGS --exclude tags --exclude 
modversions.h --exclude install-kernel 
linux-2.3.99-pre-6-2-rusty/net/ipv4/netfilter/ip_tables.c 
working/net/ipv4/netfilter/ip_tables.c
--- linux-2.3.99-pre-6-2-rusty/net/ipv4/netfilter/ip_tables.c   Fri Apr 14 
17:41:01 2000
+++ working/net/ipv4/netfilter/ip_tables.c      Wed Apr 19 15:35:04 2000
@@ -1094,7 +1099,7 @@
        /* Silent error: too late now. */
        copy_to_user(tmp.counters, counters,
                     sizeof(struct ipt_counters) * tmp.num_counters);
-
+       vfree(counters);
        up(&ipt_mutex);
        return 0;
 
--
Hacking time.

<Prev in Thread] Current Thread [Next in Thread>
  • [PATCH] Memory leak in iptables, Rusty Russell <=