netdev
[Top] [All Lists]

Re: [4/4] [IPSEC] Store MTU at each xfrm_dst

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [4/4] [IPSEC] Store MTU at each xfrm_dst
From: James Morris <jmorris@xxxxxxxxxx>
Date: Tue, 15 Feb 2005 10:53:11 -0500 (EST)
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, YOSHIFUJI Hideaki <yoshfuji@xxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>
In-reply-to: <20050214221607.GC18465@gondor.apana.org.au>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 15 Feb 2005, Herbert Xu wrote:

> Finally this is the patch that sets the MTU values of each xfrm_dst
> and keeps it up-to-date.
>   
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
> 
> To recap, at this point we've obtained accurate MTU values at each
> xfrm_dst.  The next step would be to start using it as
> dst_pmtu(xfrm_dst).

Nice work.

The only thing I'd suggest is to consider renaming the new route element
of xfrm_dst to xfrm_dst_route (or xd_route), to make it easier to navigate
the code.  (But the other elements are not distinctive either so perhaps 
some future cleanup could do it).


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>