Re: Asynchronous crypto layer.

[James Morris <jmorris@xxxxxxxxxx>]

On Tue, 2 Nov 2004, Evgeniy Polyakov wrote:

Some feedback:

+#define session_completed(s)   (s->ci.flags & SESSION_COMPLETED)
+#define complete_session(s)    do {s->ci.flags |= SESSION_COMPLETED;} while(0)
+#define uncomplete_session(s)  do {s->ci.flags &= ~SESSION_COMPLETED;} while 
(0)
etc.

Please use static inlines for all of these things.
Are these supposed to be exported to userspace?  Why?


+struct crypto_conn_data
+{
+       char                    name[SCACHE_NAMELEN];
+       __u16                   cmd;

Again, exporting to userspace?


+       list_for_each_entry_safe(__dev, n, &cdev_list, cdev_entry)
+       {
+               if (compare_device(__dev, dev))
+               {

Incorrect coding style (and many more).

As mentioned before, pluggable load balacers are not needed now, and 
complicate the code.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>