netdev
[Top] [All Lists]

Re: RFC: pskb_expand_head instead of skb_copy in skb_checksum_help

To: "David S. Miller" <davem@xxxxxxxxxx>
Subject: Re: RFC: pskb_expand_head instead of skb_copy in skb_checksum_help
From: James Morris <jmorris@xxxxxxxxxx>
Date: Tue, 24 Aug 2004 16:53:16 -0400 (EDT)
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>
In-reply-to: <20040824115541.52955b2a.davem@redhat.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 24 Aug 2004, David S. Miller wrote:

> On Tue, 24 Aug 2004 21:05:32 +1000
> Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:
> 
> > The idea is simple.  None of the callers of skb_checksum are passing it
> > skb's which are shared.  They may be cloned however.  But the application
> > checksum is always in the skb header so there is no need to linearise it.
> 
> What about looping back of multicast packets via netif_rx(),
> is that handled correctly too?

They are clones.  I can easily regression test it if needed.


- James
-- 
James Morris
<jmorris@xxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>