Re: [PATCH] Fix checksum bug for multicast/broadcast packets on postrouting hook

[James Morris <jmorris@xxxxxxxxxx>]

On Mon, 16 Feb 2004, Mika Penttilä wrote:

> James Morris wrote:
> 
> >No, it's not needed by all callers, and is just a does-one-thing helper 
> >function.
> >
> >
> It is needed for cloned skbs, so check for this should go in 
> skb_checksum_help().

No, there is no need to bloat a simple helper function out with this 
(and then need to handle OOM internally etc.), and it is not appropriate 
for all callers.

- James
-- 
James Morris
<jmorris@xxxxxxxxxx>