On Mon, 21 Jun 2004, Andrew Morton wrote:
> The loopback_stats handling looks wrong:
> .....
>
> each get_cpu_ptr() does get_cpu(), which increments preempt_count(). But
> there is only a single put_cpu_ptr() in there.
Correct. At least one person has tripped over this already. (See "Re:
[2.6.7-bk] NFS-related kernel panic" on lkml.)
> .....
>
> This compiles, but does need runtime testing.
>
I made one small change in get_stats() and tested with a preemptible
kernel on a 32p system. Looks good. The tested patch is attached.
--
Arthur
patch.preempt_bug
Description: patch for preempt count bug
|