| To: | Maciej Soltysiak <solt2@xxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [2.6.12-rc1-mm4] swapped memset arguments |
| From: | Jesper Juhl <juhl-lkml@xxxxxx> |
| Date: | Sun, 3 Apr 2005 00:38:54 +0200 (CEST) |
| Cc: | "James P. Ketrenos" <ipw2100-admin@xxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx |
| In-reply-to: | <74334709.20050402233007@dns.toxicfilms.tv> |
| References: | <74334709.20050402233007@dns.toxicfilms.tv> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sat, 2 Apr 2005, Maciej Soltysiak wrote:
> Hi,
>
> out of boredom I grepped 2.6.12-rc1-mm4 for swapped memset arguments.
> I found one:
>
> # grep -nr "memset.*\,\(\ \|\)0\(\ \|\));" *
> net/ieee80211/ieee80211_tx.c:226: memset(txb, sizeof(struct
> ieee80211_txb), 0);
>
And here's a patch :
Fix swapped memset() arguments in net/ieee80211/ieee80211_tx.c
found by Maciej Soltysiak.
Signed-off-by: Jesper Juhl <juhl-lkml@xxxxxx>
--- linux-2.6.12-rc1-mm4-orig/net/ieee80211/ieee80211_tx.c 2005-03-31
21:20:08.000000000 +0200
+++ linux-2.6.12-rc1-mm4/net/ieee80211/ieee80211_tx.c 2005-04-03
00:34:22.000000000 +0200
@@ -223,7 +223,7 @@ struct ieee80211_txb *ieee80211_alloc_tx
if (!txb)
return NULL;
- memset(txb, sizeof(struct ieee80211_txb), 0);
+ memset(txb, 0, sizeof(struct ieee80211_txb));
txb->nr_frags = nr_frags;
txb->frag_size = txb_size;
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: IPSEC: on behavior of acquire, Thomas Graf |
|---|---|
| Next by Date: | Re: Linux support for RDMA (was: [Ksummit-2005-discuss] Summary of 2005 Kernel Summit Proposed Topics), Grant Grundler |
| Previous by Thread: | ICS1883 LAN PHY not detected, David Liontooth |
| Next by Thread: | Re: [2.6.12-rc1-mm4] swapped memset arguments, Denis Vlasenko |
| Indexes: | [Date] [Thread] [Top] [All Lists] |