Re: [PATCH] net, ipv6: remove redundant NULL checks before kfree in ip6_flowlabel.c

[Jesper Juhl <juhl-lkml@xxxxxx>]

On Thu, 17 Mar 2005, YOSHIFUJI Hideaki / [iso-2022-jp] µÈÆ£±ÑÌÀ wrote:

> In article <Pine.LNX.4.62.0503170027390.2558@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> 
> (at Thu, 17 Mar 2005 00:36:35 +0100 (CET)), Jesper Juhl <juhl-lkml@xxxxxx> 
> says:
> 
> > I considered also rewriting the 
> >         if (fl)
> >                 fl_free(fl);
> > bit as simply fl_free(fl) as well, but that if() potentially saves two 
> > calls to kfree() inside fl_free as well as the call to fl_free itself, so 
> > I guess that's worth the if().
> 
> I don't mind calling kfree twice itself (because that function is not
> so performance critical), but fl_free(NULL) is out because
> if fl is NULL, kfree(fl->opt) is out.
> 
Yes, you are right ofcourse. 
Thanks.

-- 
Jesper