netdev
[Top] [All Lists]

Re: [PATCH] remove unused variables in net/sunrpc/auth.c

To: Adrian Bunk <bunk@xxxxxxxxx>
Subject: Re: [PATCH] remove unused variables in net/sunrpc/auth.c
From: Jesper Juhl <juhl-lkml@xxxxxx>
Date: Tue, 11 Jan 2005 17:18:22 +0100 (CET)
Cc: Jesper Juhl <juhl-lkml@xxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, linux-net <linux-net@xxxxxxxxxxxxxxx>, netdev <netdev@xxxxxxxxxxx>
In-reply-to: <20050110221651.GA29578@stusta.de>
References: <Pine.LNX.4.61.0501102239000.2987@dragon.hygekrogen.localhost> <20050110221651.GA29578@stusta.de>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 10 Jan 2005, Adrian Bunk wrote:

> On Mon, Jan 10, 2005 at 10:50:34PM +0100, Jesper Juhl wrote:
> > 
> > We have a few unused variables in net/sunrpc/auth.c:320:
> > 
> > net/sunrpc/auth.c:320: warning: unused variable `auth'
> > net/sunrpc/auth.c:333: warning: unused variable `auth'
> > net/sunrpc/auth.c:345: warning: unused variable `auth'
> > net/sunrpc/auth.c:385: warning: unused variable `auth'
> > 
> > As far as I can see, the patch that caused them to become unused is this 
> > one (which btw is ~36 months old) :
> > http://linux.bkbits.net:8080/linux-2.6/diffs/net/sunrpc/auth.c@xxx?nav=index.html|src/|src/net|src/net/sunrpc|hist/net/sunrpc/auth.c
> > 
> > Here is a patch to get rid of them (compile tested only).
> >...
> 
> Doesn't this break with CONFIG_SYSCTL=y?
> 
Yes, yes it does. I didn't see the CONFIG_SYSCTL connection and thus 
didn't test that :(   
Please disregard the patch, it's wrong.

-- 
Jesper Juhl



<Prev in Thread] Current Thread [Next in Thread>