netdev
[Top] [All Lists]

Re: 2.6.4-rc1 + hp100 EISA, not working

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: 2.6.4-rc1 + hp100 EISA, not working
From: Pawel Sokolowski <falcon@xxxxxxxxxxxxxxx>
Date: Thu, 4 Mar 2004 06:04:24 +0100 (CET)
Cc: mzyngier@xxxxxxxxxxx, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx
In-reply-to: <20040303122541.4dbcf0fc@dell_ss3.pdx.osdl.net>
References: <Pine.LNX.4.58.0402292149230.25624@don.falconne.eu.org> <wrpk724yicq.fsf@hina.wild-wind.fr.eu.org> <20040303122541.4dbcf0fc@dell_ss3.pdx.osdl.net>
Reply-to: pawel.sokolowski@xxxxxxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
I've seen things you people wouldn't believe. You writing:
>> Pawel> On 2.6.3 it just Oopsed and didn't work. On 2.6.4-rc1 it does
>> Pawel> not oops but it doesn't work (neither as module nor as build in 
>> kernel).
>> Note that hp100 in 2.6.4-rc1 is still broken wrt EISA probing, since
>> it lacks the terminating entry in the EISA ID list. This one-liner
>> should take care of random crashes that are often reported to LKML :
>>
>> ===== drivers/net/hp100.c 1.24 vs edited =====
>> --- 1.24/drivers/net/hp100.c Wed Feb 18 13:39:41 2004
>> +++ edited/drivers/net/hp100.c       Mon Mar  1 11:18:00 2004
>> @@ -201,6 +201,7 @@
>>      { "HWP1990" }, /* HP J2577 */
>>      { "CPX0301" }, /* ReadyLink ENET100-VG4 */
>>      { "CPX0401" }, /* FreedomLine 100/VG */
>> +    { "" }         /* Mandatory final entry ! */
>>  };
>>  MODULE_DEVICE_TABLE(eisa, hp100_eisa_tbl);
>>  #endif
>
>It could be that there is a typo in the hp100 eisa device list, the following
>
>--- linux-2.6/drivers/eisa/eisa-bus.c  2004-01-23 09:38:19.000000000 -0800
>+++ tcp-2.6/drivers/eisa/eisa-bus.c    2004-03-03 12:23:53.604252800 -0800
[...]
>+      printk(KERN_DEBUG "eisa_bus_match dev sig='%s' state=0x%x eids=%s\n",
>+             edev->id.sig, edev->state, eids ? eids->sig : "<null>");

With eisa_bus.enable_dev=2 I'm getting:

eisa_bus_match dev sig='HWPC061' state=0x1 eids=HWPF180
eisa_bus_match dev sig='HWP1940' state=0x3 eids=HWPF180

without:

eisa_bus_match dev sig='HWPC061' state=0x1 eids=HWPF180
eisa_bus_match dev sig='HWP1940' state=0x0 eids=HWPF180

when modprobing hp100.

-- 
  ,d$$$$$P.d$$b     d$P  ,gd$$$$$,gd$$$$g. ,$$$b._$$P               RLU #172534
  ggggggggggggg.   ggs  ,gg     ,gg    ,gg ggp,ggggg           Paweł Sokołowski
 d$P""""'""""Y$$. d$P   d$P     d$P   ,d$Pd$P `Y$$P      falcon@xxxxxxxxxxxxxxx
d$P           Y$$d$$$$$P`Y$$$$$'`Y$$$$$P'd$P   d$P    Replicant (M) Des: Falcon


<Prev in Thread] Current Thread [Next in Thread>