On Fri, 27 Feb 2004, David S. Miller wrote:
> On Fri, 27 Feb 2004 12:31:18 -0800 (PST)
> Sridhar Samudrala <sri@xxxxxxxxxx> wrote:
>
> > Thanks for fixing the MSECS_TO_JIFFIES warning.
>
> No problem. Maybe we want to rename some of those other macros
> to have SCTP_ prefixes too?
Are you referring to JIFFIES_TO_MSECS? Do you see any other macros that need
renaming? I think rest of the macros do have SCTP_ prefix.
As Jeff said, may be we should make them generic?
Is include/linux/time.h a good place?
looking at the other implementations
from net/irda/irda.h
#define MSECS_TO_JIFFIES(ms) (((ms)*HZ+999)/1000)
form include/linux/libata.h
static inline unsigned long msecs_to_jiffies(unsigned long msecs)
{
return ((HZ * msecs + 999) / 1000);
}
Won't these overflow for large msec values.
Thanks
Sridhar
|