netdev
[Top] [All Lists]

Re: [PATCH] Drop ISA dependencies from IRDA drivers

To: Andi Kleen <ak@xxxxxx>
Subject: Re: [PATCH] Drop ISA dependencies from IRDA drivers
From: Martin Diehl <lists@xxxxxxxxx>
Date: Fri, 16 Jul 2004 00:32:44 +0200 (CEST)
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, <netdev@xxxxxxxxxxx>, <irda-users@xxxxxxxxxxxxxxxxxxxxx>, <jt@xxxxxxxxxx>, <the_nihilant@xxxxxxxxxxxxx>, Linux Kernel <linux-kernel@xxxxxxxxxxxxxxx>
In-reply-to: <20040715215552.GA46635@muc.de>
Sender: netdev-bounce@xxxxxxxxxxx
On 15 Jul 2004, Andi Kleen wrote:

> Remove wrong ISA dependencies for IRDA drivers.
> 
> 
> diff -u linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o 
> linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig
> --- linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig-o   2004-07-12 
> 06:09:05.000000000 +0200
> +++ linux-2.6.8rc1-amd64/drivers/net/irda/Kconfig     2004-07-15 
> 18:33:48.000000000 +0200
> @@ -310,7 +310,7 @@
>  
>  config NSC_FIR
>       tristate "NSC PC87108/PC87338"
> -     depends on IRDA && ISA
> +     depends on IRDA


Admittedly I haven't tried either, but I'm pretty sure this patch will 
break building those drivers because they are calling irda_setup_dma - 
which is CONFIG_ISA. Maybe this can be dropped but I don't see what's 
wrong with !64BIT instead.

Martin


<Prev in Thread] Current Thread [Next in Thread>