Re: [ROUTE] PMTU only works on half the time

[Julian Anastasov <ja@xxxxxx>]

        Hello,

On Tue, 2 Dec 2003, Herbert Xu wrote:

> On Tue, Dec 02, 2003 at 07:16:51AM +1100, herbert wrote:
> >
> > I found out that PMTU only works on those routing cache entries where
> > rt_src != 0.  This patch should make it work for all matching entries.
>
> That patch removed one line too many.  This one should be better.

        IMO, the rt_src check in ip_rt_frag_needed is ok.

        I would suspect all rth->fl.fl4_tos checks too.
It seems we need toskeys[2] and a second for loop if tos!=0.
What about rewriting them to (rth->fl.fl4_tos == toskeys[j]).

Regards

--
Julian Anastasov <ja@xxxxxx>