| To: | Stephen Hemminger <shemminger@xxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] sdla non-module build fix. |
| From: | Linus Torvalds <torvalds@xxxxxxxx> |
| Date: | Mon, 8 Sep 2003 10:32:26 -0700 (PDT) |
| Cc: | Jeff Garzik <jgarzik@xxxxxxxxx>, <netdev@xxxxxxxxxxx> |
| In-reply-to: | <20030908095708.107b98c4.shemminger@osdl.org> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Mon, 8 Sep 2003, Stephen Hemminger wrote:
>
> Last round of changes broke sdla build if not a module.
This patch can't be right. It may fix the compile, but it looks like
init/exit_sdla is never registered at all if it's built-in.
I suspect the whole #ifdef should go away. A driver that does things
differently depending on whether it is a module or not is generally a
_broken_ driver.
Linus
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH] sdla non-module build fix., Stephen Hemminger |
|---|---|
| Next by Date: | Re: [PATCH] sdla non-module build fix., Stephen Hemminger |
| Previous by Thread: | [PATCH] sdla non-module build fix., Stephen Hemminger |
| Next by Thread: | Re: [PATCH] sdla non-module build fix., Stephen Hemminger |
| Indexes: | [Date] [Thread] [Top] [All Lists] |