netdev
[Top] [All Lists]

Re: PATCH: IPSec not using padding when Null Encryption

To: latten@xxxxxxxxxxxxxx
Subject: Re: PATCH: IPSec not using padding when Null Encryption
From: James Morris <jmorris@xxxxxxxxxxxxxxxx>
Date: Fri, 28 Feb 2003 12:01:10 +1100 (EST)
Cc: davem@xxxxxxxxxx, <kuznet@xxxxxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>
In-reply-to: <200302272129.h1RLTJW28434@faith.austin.ibm.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 27 Feb 2003 latten@xxxxxxxxxxxxxx wrote:

> I have tested it. Please let me know if all is well. 

Looks fine to me.

(Perhaps change the name of the blksize variable to padto or similar, in 
case someone later thinks it's the real block size).

> --- esp.c.orig        2003-02-20 16:07:59.000000000 -0600
> +++ esp.c     2003-02-27 10:30:25.000000000 -0600
> @@ -360,7 +360,7 @@
>       esp = x->data;
>       alen = esp->auth.icv_trunc_len;
>       tfm = esp->conf.tfm;
> -     blksize = crypto_tfm_alg_blocksize(tfm);
> +     blksize = (crypto_tfm_alg_blocksize(tfm) + 3) & ~3;
>       clen = (clen + 2 + blksize-1)&~(blksize-1);
>       if (esp->conf.padlen)
>               clen = (clen + esp->conf.padlen-1)&~(esp->conf.padlen-1);
> 

-- 
James Morris
<jmorris@xxxxxxxxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>