netdev
[Top] [All Lists]

Re: [PATCH] fixes the type of 'index' in struct open_request

To: kuznet@xxxxxxxxxxxxx, davem@xxxxxxxxxx
Subject: Re: [PATCH] fixes the type of 'index' in struct open_request
From: Sridhar Samudrala <samudrala@xxxxxxxxxx>
Date: Fri, 7 Sep 2001 16:35:12 -0700 (PDT)
Cc: Sridhar Samudrala <samudrala@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <200109071749.VAA01322@ms2.inr.ac.ru>
Sender: owner-netdev@xxxxxxxxxxx
On Fri, 7 Sep 2001 kuznet@xxxxxxxxxxxxx wrote:

> >     probably the reason why it was not noticed till now.
> 
> No, I remember this. It is an explicit padding now, though
> initialization should be deleted yet.

If index is not used and there is no need for it and only used as padding,
then the initialization needs to be removed in tcp_v4_synq_add().

--- tcp_ipv4.c.orig     Fri Sep  7 16:22:26 2001
+++ tcp_ipv4.c  Fri Sep  7 16:22:59 2001
@@ -781,7 +781,6 @@
        req->expires = jiffies + TCP_TIMEOUT_INIT;
        req->retrans = 0;
        req->sk = NULL;
-       req->index = h;
        req->dl_next = lopt->syn_table[h];
 
        write_lock(&tp->syn_wait_lock);

Thanks
Sridhar


<Prev in Thread] Current Thread [Next in Thread>