Dave,
That email got lost in the shuffle. Apologies.
I cant think of any clever way that wont have a cost to it. One way could
be just to get rid of the new define in the patch (means modules will have
this extra static variable they dont use).
OTOH, we could fix this from netfilter. I remember discussing this with
Harald and sending him a small patchlet. I hope he's on the list.
The check if (nf_register_hook(&ing_ops) < 0) is basically useless.
The return is always succesful. Adding the same hook twice does not make
any semantic sense in netfilter and as can be seen creates a oops.
If nf_register_hook() returns something like -EREGISTERED life would be
good.
cheers,
jamal
On Thu, 20 Sep 2001, David S. Miller wrote:
> From: Julian Anastasov <ja@xxxxxx>
> Date: Wed, 12 Sep 2001 12:46:57 +0300 (EEST)
>
> The diffserv guys know about this bug for already more than
> 2 months. What is going on, guys? I'm appending a modified version of
> the patch posted to diffserv list on June 24, from Doron Oz. It is against
> 2.4. In short, the ingress support should not register itself twice to
> netfilter.
>
> What is going on is that these fixes add more MODULE ifdefs, there
> shouldn't be any new MODULE ifdefs added to the kernel these days.
>
> I told Jamal (who first sent me this fix) to fixup the patch so that
> the MODULE ifdefs were all removed, but it slipped through the cracks.
>
> Later,
> David S. Miller
> davem@xxxxxxxxxx
>
|