Re: kfree_skb: unnecessary check ?

["Thomas 'Dent' Mirlacher" <dent@xxxxxxxxxxxxxx>]

patrick,

--snip/snip
> static inline void kfree_skb(struct sk_buff *skb)
> {
-     if (atomic_read(&skb->users) == 1)
+     if (likely(atomic_read(&skb->users) == 1))
>         __kfree(skb);
>     else
>         atomic_dec(&skb->users);
> }

is even faster for the likely case by 1 2 jmps (gcc3.1).
(well, is it the likely case?)

        tm

-- 
in some way i do, and in some way i don't.