netdev
[Top] [All Lists]

Re: kern-25-net-core-bug

To: d_vangreg <d.vangreg@xxxxxxxxx>
Subject: Re: kern-25-net-core-bug
From: "Thomas 'Dent' Mirlacher" <dent@xxxxxxxxxxxxxx>
Date: Wed, 1 May 2002 20:35:37 +0200 (MET DST)
Cc: netdev@xxxxxxxxxxx
In-reply-to: <200205011800.g41I0WwJ029694@oss.sgi.com>
Sender: owner-netdev@xxxxxxxxxxx
--snip/snip

> I guessed (as errata):     ret=handle_diverter(skb);
> 
> & tried  (as corrige):     handle_diverter(skb);

well, a cleaner thing would be to set ret=0 or ret=
... but on the other hand, the return value for netif_receive_skb
isn't checked (at least in process_backlog)

btw. is someone auditing the network code?
- like check all return values from functions which could fail.

        ++dent

-- 
in some way i do, and in some way i don't.


<Prev in Thread] Current Thread [Next in Thread>