netdev
[Top] [All Lists]

Re: [patch 10/13] net/socket.c::sys_bind() cleanup.

To: Luiz Fernando Capitulino <lcapitulino@xxxxxxxxxxxxxxxx>
Subject: Re: [patch 10/13] net/socket.c::sys_bind() cleanup.
From: David Stevens <dlstevens@xxxxxxxxxx>
Date: Wed, 24 Nov 2004 14:03:17 -0800
Cc: akpm@xxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, jgarzik@xxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <41A4688E.80908@conectiva.com.br>
Sender: netdev-bounce@xxxxxxxxxxx
It's just a style issue, so maybe you'll disagree, but I prefer:

        if (!sock)
                return err;

to your

        if (!sock)
                goto out;
...
out:
        return err;

        I think "return err" is more readable than "goto out/return err" 
for
that path and having another "return err" for the out-with-put case isn't 
a
terrible thing.

                                +-DLS


<Prev in Thread] Current Thread [Next in Thread>