netdev
[Top] [All Lists]

Re: [PATCH] [1/2] kernel error reporting (revised)

To: Jim Keniston <jkenisto@xxxxxxxxxx>
Subject: Re: [PATCH] [1/2] kernel error reporting (revised)
From: James Morris <jmorris@xxxxxxxxxxxxxxxx>
Date: Sun, 20 Jul 2003 09:52:33 +1000 (EST)
Cc: Andrew Morton <akpm@xxxxxxxx>, <davem@xxxxxxxxxx>, <linux-kernel@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <jgarzik@xxxxxxxxx>, <alan@xxxxxxxxxxxxxxxxxxx>, <rddunlap@xxxxxxxx>, <kuznet@xxxxxxxxxxxxx>
In-reply-to: <3F1882CF.538FE76@us.ibm.com>
Sender: netdev-bounce@xxxxxxxxxxx
On Fri, 18 Jul 2003, Jim Keniston wrote:

> > Yes, this makes sense.  At the kerror.c level, just return -EDEADLK if 
> > in_irq().
> > Delay packet delivery (via a tasklet, as before) at the evlog.c level 
> > instead.
> > That way, we know at the evlog.c level (in the tasklet) whether the event 
> > packet
> > was delivered to anybody, and can paraphrase it to printk if it wasn't.
> >
> > Is this the sort of thing you had in mind?

Not exactly -- I don't think the logging framework should do any irq 
detection.  The caller should either know if its in an interrupt, or do 
the detection itself.


- James
-- 
James Morris
<jmorris@xxxxxxxxxxxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>