netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] IPV4 IPComp : threshold comparison

from [James Morris] [Permanent Link][Original]
To: Mitsuru KANDA / 神田 充 <mk@xxxxxxxxxxxxxx>
Subject: Re: [PATCH] IPV4 IPComp : threshold comparison
From: James Morris <jmorris@xxxxxxxxxxxxxxxx>
Date: Sun, 18 May 2003 11:07:10 +1000 (EST)
Cc: davem@xxxxxxxxxx, <kuznet@xxxxxxxxxxxxx>, <netdev@xxxxxxxxxxx>, <usagi@xxxxxxxxxxxxxx>
In-reply-to: <87smrda4q6.wl@karaba.org>
Sender: netdev-bounce@xxxxxxxxxxx 
On Sun, 18 May 2003, Mitsuru KANDA / [ISO-2022-JP] $B?@ED(B $B=<(B wrote:

> I'm not sure how exactly we should check threshold.

We should check the length of the IP payload, which the current code is 
only currently doing for tunnel mode.

> In IPsec tunnel mode, the original comparison code 
> seems to be including IP header length.

It is counting the inner IP header, which is correct, as it is part of the 
final IP payload.  The transport mode calculation is incorrect.

> Could you check it?

Your patch fixes the calculation for transport mode, and looks correct.


- James
-- 
James Morris
<jmorris@xxxxxxxxxxxxxxxx>
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH] IPv6 IPComp, David S. Miller
Next by Date:  [PATCH][IPV6] compile fix for net/ipv6/route.c in current bk, James Morris
Previous by Thread:  [PATCH] IPV4 IPComp : threshold comparison, Mitsuru KANDA / 神田 充
Next by Thread:  Re: [PATCH] IPV4 IPComp : threshold comparison, David S. Miller
Indexes:  [Date] [Thread] [Top] [All Lists]