Re: [PATCH 2/3] add open iscsi netlink interface to iscsi transport class

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

YOSHIFUJI Hideaki / ???? <yoshfuji@xxxxxxxxxxxxxx> wrote:
> In article <42798AC1.2010308@xxxxxxxxxxx> (at Wed, 04 May 2005 19:53:53 
> -0700), Mike Christie <michaelc@xxxxxxxxxxx> says:
> 
>> +struct iscsi_uevent {
> :
>> +} __attribute__ ((aligned (sizeof(unsigned long))));
> 
> I think it'd be better to use sizeof(uint64_t) or something.

Is there a benefit in aligning on 64-bit boundaries for 32-bit platforms?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt